Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation WATCH_ARRAY #1648

Closed
talaxasy opened this issue Jan 14, 2023 · 7 comments · Fixed by #1695
Closed

deprecation WATCH_ARRAY #1648

talaxasy opened this issue Jan 14, 2023 · 7 comments · Fixed by #1695
Assignees
@mattelen
Labels
3.0
Milestone
3.0.0-beta.2 - Fi...

Comments

@talaxasy
Copy link

image

I use @vue/compat to migrate from vue 2 to vue 3.
Compat indicates that property 'options' in VueMultiselect component in watch-effect no deep marker
@akki-jat
Copy link
Collaborator

@talaxasy Is this happening for vue-multiselect 2.x or 3.x?

@talaxasy
Copy link
Author

@akki-jat vue-multiselect 3

@akki-jat
Copy link
Collaborator

akki-jat commented Feb 4, 2023

@talaxasy Please provide reproducible link.

@jkocyigi
Copy link

jkocyigi commented Feb 27, 2023 •
edited
Loading

@akki-jat Created a sandbox for you

https://codesandbox.io/p/sandbox/spring-rgb-wr6gzw?file=%2Fsrc%2Fmain.js&selection=%5B%7B%22endColumn%22%3A1%2C%22endLineNumber%22%3A14%2C%22startColumn%22%3A1%2C%22startLineNumber%22%3A14%7D%5D

Think by add the deep: true to the internalValue watch should resolve the warning, but I don't know how that would affect the rest of the code.

@carvemerson
Copy link

Same issue here. A lot of warnings.
Do you have any plans to deploy a stable version os this component that is compatible with vue3?

@mattelen mattelen self-assigned this May 5, 2023
@mattelen mattelen mentioned this issue May 5, 2023
Merged
@mattelen
Copy link
Collaborator

mattelen commented May 9, 2023

Fixed and launched on v3.0.0-beta.2

@mattelen mattelen closed this as completed May 9, 2023
@mattelen
Copy link
Collaborator

mattelen commented May 9, 2023

Same issue here. A lot of warnings. Do you have any plans to deploy a stable version os this component that is compatible with vue3?

Check out #1589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattelen mattelen

Labels
3.0
Projects
None yet
Milestone
3.0.0-beta.2 - Fix Vue Compat warnings
Development

Successfully merging a pull request may close this issue.

1648 deprecation watch array shentao/vue-multiselect
5 participants
@carvemerson @mattelen @talaxasy @akki-jat @jkocyigi