-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TODO #1
Comments
please add automatic detection for using shell or not-use. (like this https://github.com/mmstick/parallel/blob/0dd48100e9a29d9a023826c778a5c7e70f9bf464/src/execute/exec_inputs.rs#L40-L45) |
OK. I'll use mattn/go-shellwords |
go-shellwords doesn't detect multiple commands like https://www.reddit.com/r/rust/comments/5penft/parallelizing_enjarify_in_go_and_rust/dcr4y7f/ |
I think running all commands using shell ( |
What I mean is |
I get it. Thanks you. |
@mattn Running commands within a shell has very little overhead for my Rust implementation when you follow the recommendation to install dash. Here's a comparison of times with and without the shell: Without Shell
With ShellThese are times when the shell is enabled (with
Believe it or not, but the shell path with dash is actually much faster than the no-shell path. That is something that I will be investigating, to see where my bottleneck is in regards to the no-shell codepath. |
@mmstick The rust implementation is indeed faster for this test. And the go API for running a process needs to call What made me confused was why Here's a fresh result:
Besides, speed is not the #.1 target for |
Do you have any AMD hardware? Both of my systems are powered with AMD so that could be one reason. It could also be the Intel CPU governor having issues of not retaining it's max frequency long enough. Basically, before I perform my benchmarks, I ensure that all software is closed, that the CPU governor is set to |
Would it be possible to process a set of commands that is specified in a file, for example like the "::::" argument in GNU parallel? |
@mfasold |
{^suffix}
for removing suffix--eta
The text was updated successfully, but these errors were encountered: