Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using only 1 batch per timestamp in the training examples #90

Open
YanivDorGalron opened this issue Jun 14, 2024 · 1 comment
Open

Using only 1 batch per timestamp in the training examples #90

YanivDorGalron opened this issue Jun 14, 2024 · 1 comment

Comments

@YanivDorGalron
Copy link

Hey,

Would really appreciate your help here:

It seems like only 1 batch is used per timestamp

label_t = dataset.get_label_time() # check when does the first label start

This line is used to find out in which timestamp the first labeled node appear.
After that for each batch we check if the last timestamp is above label_t here

Till here its all good
The problem is that after that we immeadatly change label_t to be the current timestamp here

In my opinion this cause the training to consider only the first batch at every timestamp and not all the batches that are labeled.

Could you please provide clarification regarding this?

Thanks in advance
Yaniv

@YanivDorGalron YanivDorGalron changed the title using only 1 batch per timestamp in the training examples Using only 1 batch per timestamp in the training examples Jun 14, 2024
@YanivDorGalron
Copy link
Author

I think the answer to this is as follows: In some datasets, the batch size is smaller than the total amount of interactions in a single timestamp. In those cases, we would like to evaluate ourselves only on the first batch of the timestamp; otherwise, the next batches in the discussed timestamp will be affected by the first batch and so on.

A solution to this could have been - to process edges only after all interactions from a specific timestamp have been evaluated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant