Skip to content

Commit c6c1f3e

Browse files
committed
Deprecate Python 3.8
Python 3.8 is nearing EOL, and it's being deprecated here to allow for more ready dependency resolution between pandas and numpy, avoiding a fatal import. Resolves #2266.
1 parent 47ab466 commit c6c1f3e

File tree

5 files changed

+5
-9
lines changed

5 files changed

+5
-9
lines changed

.github/workflows/regression.yml

-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ jobs:
4949
macos-latest,
5050
]
5151
python-version: [
52-
'3.8',
5352
'3.9',
5453
'3.10',
5554
'3.11',

pyproject.toml

+2-3
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,15 @@ repository = "https://github.com/sherlock-project/sherlock"
4040
"Bug Tracker" = "https://github.com/sherlock-project/sherlock/issues"
4141

4242
[tool.poetry.dependencies]
43-
python = "^3.8"
43+
python = "^3.9"
4444
certifi = ">=2019.6.16"
4545
colorama = "^0.4.1"
4646
PySocks = "^1.7.0"
4747
requests = "^2.22.0"
4848
requests-futures = "^1.0.0"
4949
stem = "^1.8.0"
5050
torrequest = "^0.1.0"
51-
# pandas can likely be bumped up to ^2.0.0 after fc39 EOL
52-
pandas = ">=1.0.0,<3.0.0"
51+
pandas = "^2.2.1"
5352
openpyxl = "^3.0.10"
5453

5554
[tool.poetry.extras]

sherlock_project/__main__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
# Check if the user is using the correct version of Python
1515
python_version = sys.version.split()[0]
1616

17-
if sys.version_info < (3, 8):
18-
print(f"Sherlock requires Python 3.8+\nYou are using Python {python_version}, which is not supported by Sherlock.")
17+
if sys.version_info < (3, 9):
18+
print(f"Sherlock requires Python 3.9+\nYou are using Python {python_version}, which is not supported by Sherlock.")
1919
sys.exit(1)
2020

2121
from sherlock_project import sherlock

tests/sherlock_interactives.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ def run_cli(args:str = "") -> str:
2020
raise InteractivesSubprocessError(e.output.decode())
2121

2222

23-
# -> list[str] is prefered, but will require deprecation of support for Python 3.8
24-
def walk_sherlock_for_files_with(pattern: str) -> list:
23+
def walk_sherlock_for_files_with(pattern: str) -> list[str]:
2524
"""Check all files within the Sherlock package for matching patterns"""
2625
pattern:re.Pattern = re.compile(pattern)
2726
matching_files:list[str] = []

tox.ini

-1
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,3 @@ python =
4141
3.11: py311
4242
3.10: py310
4343
3.9: py39
44-
3.8: py38

0 commit comments

Comments
 (0)