Fix Invalid usernames for number of pages #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with long not valid username
ppfeister
approved these changes
Nov 2, 2024
1 task
|
Changes reverted. Upon further review, some patterns seem to be incorrect, even if the absurdly long usernames are dealt with. For instance, Discord allows periods, HackTheBox allows up to 32 chars, etc. Corrections are welcome if desired. Should also note that when within length, F+s are still present. |
|
It's good to know that these patterns didn't work.Well done for reverting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I add
regexCheckvalue indata.jsonfile that will check for valid username in the web pages related to this issue #2313.Its minimize the chance to return a result for a invalid username as the rules for username from the pages is considered also