Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShExC production rule 19 for shapeAtomNoRef is never used #30

Open
marcelotto opened this issue Apr 26, 2019 · 2 comments
Open

ShExC production rule 19 for shapeAtomNoRef is never used #30

marcelotto opened this issue Apr 26, 2019 · 2 comments

Comments

@marcelotto
Copy link
Contributor

marcelotto commented Apr 26, 2019

The grammars from the https://github.com/shexSpec/grammar repo don't include this production at all, so I assume it can be removed here. If you confirm, I can create a PR.

@ericprud
Copy link

ericprud commented May 8, 2019

apologies for the delay -- We'll need to look at a couple implementations which pass all the syntax tests and make sure that i'm not simply missing the ref to shapeAtomNoRef. @hsolbrig , can you intelli-diff (i.e. look hard at) the delta between the 2.1 grammar and what's in the spec?

@marcelotto
Copy link
Contributor Author

I will deliver an additional implementation (hopefully) soon, which will be in Elixir.

Stumbled across various issues with the current grammar in the specs to make the syntax tests pass. For some I've created PRs. Another problem I had, were with the tests using wildcard exclusions, for which the grammar is not up-to-date. But this wasn't even covered in the informal parts, so I was unsure about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants