Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QLoRA and DDP #4

Open
mrT23 opened this issue Aug 28, 2023 · 3 comments
Open

QLoRA and DDP #4

mrT23 opened this issue Aug 28, 2023 · 3 comments
Labels
question Further information is requested wontfix This will not be worked on

Comments

@mrT23
Copy link

mrT23 commented Aug 28, 2023

Thanks for the great repo

i have two questions about training the models (specifically WizardCoder):

  1. have you tried training with QLoRa, and not just LoRa ? are you considering adding it to the repo ?

  2. the example usage (https://github.com/shibing624/CodeAssist#train-wizardcoder-model) is without ddp, only dp.
    are you sure this is the optimal setting? We got significantly higher training rates with ddp

@mrT23 mrT23 added the question Further information is requested label Aug 28, 2023
@shibing624
Copy link
Owner

shibing624 commented Aug 29, 2023

  1. qlora will add, next week. qlora done in my repo: https://github.com/shibing624/MedicalGPT
  2. use torchrun

@mrT23
Copy link
Author

mrT23 commented Aug 31, 2023

The base example is bad (no ddp)

cd examples
CUDA_VISIBLE_DEVICES=0,1 python training_wizardcoder_mydata.py --do_train --do_predict --num_epochs 1 --output_dir outputs-wizard --model_name WizardLM/WizardCoder-15B-V1.0

and there are some discrepancies in the code, that need adjustments to ddp, for example doing 'do_predict' just on the main process.

anyway, thanks for the answer, and the great code.

Copy link

stale bot commented Dec 27, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.(由于长期不活动,机器人自动关闭此问题,如果需要欢迎提问)

@stale stale bot added the wontfix This will not be worked on label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants