Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] SHIELD has not marked a task as failed, even though the agent restarted #650

Open
thomasmitchell opened this issue Nov 13, 2019 · 4 comments
Labels
triage Issues that are pending triage / validation by a SHIELD contributor
Milestone

Comments

@thomasmitchell
Copy link
Contributor

Describe the bug
The agent restarted, and its not doing that task anymore. SHIELD has not marked the task as failed in the database (it is still running). This may cause future attempts to run this task to stay pending.

To Reproduce
Steps to reproduce the behavior:

  1. Schedule a long-running backup
  2. Restart the agent running it
  3. Check the task list

Expected behavior
The backup should have been marked as failed.

Screenshots
If applicable, add screenshots to help explain your problem.

SHIELD versions (please complete the following information):

  • SHIELD Core: 8.5.0
  • SHIELD CLI: 8.5.0

Browser version(s) (please complete if reporting a web UI bug):
n/a

Additional context
Add any other context about the problem here.

@thomasmitchell thomasmitchell added the triage Issues that are pending triage / validation by a SHIELD contributor label Nov 13, 2019
@jhunt
Copy link
Contributor

jhunt commented Nov 14, 2019

I believe there is a (default, but configurable) 12h timeout after which time the task will be marked as cancelled.

@thomasmitchell
Copy link
Contributor Author

This appears to be what eventually occurred.

@thomasmitchell
Copy link
Contributor Author

Is there any way that a task can become successful if the SSH session is terminated before task completion?

@jhunt
Copy link
Contributor

jhunt commented Nov 14, 2019

Hey, I never said it was a great solution 😁

If the SSH connection fails, we should fail the task immediately. I can't wait to get this into a lab and repro it to see how you pulled this one off, @thomasmitchell ...

@jhunt jhunt added this to the v9 milestone Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Issues that are pending triage / validation by a SHIELD contributor
Development

No branches or pull requests

2 participants