You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
oniguruma-to-js was archived on 2024-11-15, after it was replaced in Shiki by oniguruma-to-es. Should the remaining references in this library be removed?
Note that the changes here should be removed because they are changing the meaning from ASCII-only to Unicode-based (Oniguruma's \d and \w are Unicode-based by default, unlike JS), so these rewrites not only change what the regexes match but might also make the regexes generated by oniguruma-to-es a bit slower to run. The searches also don't account for cases where the patterns are escaped.
And running syntaxLowering seems risky since it makes some inaccurate changes (ex: ASCII-only POSIX classes) and doesn't have full understanding of Oniguruma syntax. Maybe you could run a stripped-down version that only removes comments?
Note that, even for comments, following the rules exactly is fairly complex. Maybe syntaxLowering is already handling this well enough, but in case it's helpful, there are details for this in oniguruma-to-es's Supported features list, under:
Flags → Extended
Pattern modifiers → Group
Pattern modifiers → Directive
Other → Comment group
The text was updated successfully, but these errors were encountered:
oniguruma-to-js was archived on 2024-11-15, after it was replaced in Shiki by oniguruma-to-es. Should the remaining references in this library be removed?
Note that the changes here should be removed because they are changing the meaning from ASCII-only to Unicode-based (Oniguruma's
\d
and\w
are Unicode-based by default, unlike JS), so these rewrites not only change what the regexes match but might also make the regexes generated byoniguruma-to-es
a bit slower to run. The searches also don't account for cases where the patterns are escaped.I'm guessing this isn't needed anymore?
And running
syntaxLowering
seems risky since it makes some inaccurate changes (ex: ASCII-only POSIX classes) and doesn't have full understanding of Oniguruma syntax. Maybe you could run a stripped-down version that only removes comments?Note that, even for comments, following the rules exactly is fairly complex. Maybe
syntaxLowering
is already handling this well enough, but in case it's helpful, there are details for this inoniguruma-to-es
's Supported features list, under:The text was updated successfully, but these errors were encountered: