Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSDX -> Esbuild #11

Open
orta opened this issue Jun 8, 2021 · 3 comments
Open

TSDX -> Esbuild #11

orta opened this issue Jun 8, 2021 · 3 comments

Comments

@orta
Copy link
Contributor

orta commented Jun 8, 2021

We don't do anything complex in these libs, and requiring building individual libs so that upstream consumers can test the changes isn't a great experience. In the TS website this was less of an issue because of the build watcher.
@orta
Copy link
Contributor Author

orta commented Jun 9, 2021

https://souporserious.com/bundling-typescript-with-esbuild-for-npm/ seemed like a reasonable template

@orta
Copy link
Contributor Author

orta commented Jun 16, 2021

I think only shiki-twoslash and remark-shiki-twoslash are complicated enough to even warrant TypeScript

@orta orta mentioned this issue Jun 17, 2021
Merged
@orta
Copy link
Contributor Author

orta commented Jul 1, 2021

I've moved a few over, only the biggest players are tsdx now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orta