Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript as shared dependency in the modules. #267

Open
sidtohan opened this issue Aug 15, 2022 · 0 comments
Open

Add typescript as shared dependency in the modules. #267

sidtohan opened this issue Aug 15, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@sidtohan
Copy link
Contributor

Description

In order to prevent duplication of dependencies during the optimized build, we must add them as shared dependencies. Since typescript is now working fine for Attendance and Worksheet module, it would be good to add typescript as shared dependency in these two modules(and any others, if applicable).

Starting Point

If you wish to contribute, look in the module configuration config file for the eligible modules, and add typescript as a dependency in the list of shared dependency.

Example

For the attendance module, the config file is right now as follows:
image
Edit the list of shared dependencies and add typescript, make sure the version is consistent across all modules(the one which are using typescript that is)

@sidtohan sidtohan added the enhancement New feature or request label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant