Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong method called in ItemDetail::loadDetailByItemId #10

Closed
bmarquis opened this issue Oct 26, 2016 · 2 comments
Closed

Wrong method called in ItemDetail::loadDetailByItemId #10

bmarquis opened this issue Oct 26, 2016 · 2 comments

Comments

@bmarquis
Copy link

This calls is wrong in \ShipperHQ\Shipper\Model\Order\ItemDetail::loadDetailByItemId
$this->orderItemDetailCollection->addItemToFilter($itemId);

It should probably be calling addItemIdToFilter located here \ShipperHQ\Shipper\Model\ResourceModel\Order\ItemDetail\Collection::addItemIdToFilter:
$this->orderItemDetailCollection->addItemIdToFilter($itemId);

Thanks,
Ben

@wsagen
Copy link
Contributor

wsagen commented Nov 1, 2016

Thanks for raising also, we have a fix going out for this today.

@wsagen
Copy link
Contributor

wsagen commented Nov 2, 2016

Version 20.1.1 includes fix for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants