Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap up SyntaxHighlighter as a NativeScript component #4

Closed
shirakaba opened this issue Dec 4, 2018 · 1 comment
Closed

Wrap up SyntaxHighlighter as a NativeScript component #4

shirakaba opened this issue Dec 4, 2018 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@shirakaba
Copy link
Owner

This would require implementing at least a stub for Android, as we don't yet have Android support: #2.

I tried creating this as a component, both:

However, I couldn't get either working. One of these methods broke hot-reloading (I think the programmatic one), while the other simply wouldn't be imported by the bundler (and thus didn't get transpiled to JS) or didn't trigger expected lifecycle methods (and thus wouldn't begin to construct itself). Someone more familiar with NativeScript's intricacies may have better luck here.

I think it would be awesome to have it as an XML-specifiable component if possible, but I think I made more progress on the programmatic one in practice.

Difficulties: getting the initial bounds of the UITextView may require it to know the dimensions of its native parent in some way. I don't really know.

@shirakaba
Copy link
Owner Author

Closed by #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant