Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow disk.Partitions(true) on Windows with missing mapped network drives #1406

Open
tmm1 opened this issue Jan 10, 2023 · 1 comment
Open

Slow disk.Partitions(true) on Windows with missing mapped network drives #1406

tmm1 opened this issue Jan 10, 2023 · 1 comment

Comments

@tmm1
Copy link
Contributor

tmm1 commented Jan 10, 2023

Describe the bug
disk.Partitions(true) can take 20s+ when mapped drives exist on windows and the remote server is not available

The error returned is:

Error 0: The network path was not found.

According to http://www.delphigroups.info/2/3d/477068.html there is no timeout control
@shirou shirou mentioned this issue Jan 14, 2023
Merged
@shirou
Copy link
Owner

shirou commented Jan 14, 2023

Now I raise a PR(#1407) which adds the functionality to handle context to that method. After merging, we can use context.Withtimeout to set the appropriate timeout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmm1 @shirou