Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ICU version configurable #282

Closed
1 task done
ausi opened this issue Aug 29, 2020 · 3 comments · Fixed by #283
Closed
1 task done

Make ICU version configurable #282

ausi opened this issue Aug 29, 2020 · 3 comments · Fixed by #283
Assignees
@shivammathur
Labels
enhancement New feature or request

Comments

@ausi
Copy link

ausi commented Aug 29, 2020

Describe the feature
Make it possible to select the underlying ICU version for the intl extension.
Something like extensions: intl-icu58.1 or extensions: icu-58.1.

Version

  • I have checked releases and the feature is missing in the latest patch version of v2.

Underlying issue
Running unit tests for the lowest supported ICU version. This is quite important for projects with heavy usage of the intl extension.

Describe alternatives
Somehow installing libicu manually before PHP is built (if this is possible?)

Additional context
N/A

Are you willing to submit a PR?
I’m very new to GitHub workflows and don’t know much about setting up a PHP build 🙈
@ausi ausi added the enhancement New feature or request label Aug 29, 2020
@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Sep 2, 2020
@shivammathur
Copy link
Owner

shivammathur commented Sep 2, 2020 •
edited
Loading

@ausi Next release will have support for specifying intl-<icu_version>, for example intl-67.1 in Ubuntu workflows for PHP 5.6 to PHP 7.4. It will support ICU 50.2 and newer.

@ausi
Copy link
Author

ausi commented Sep 2, 2020

That’s awesome, thank you!

@ausi ausi mentioned this issue Sep 2, 2020
Merged
@shivammathur shivammathur mentioned this issue Sep 7, 2020
Merged
@shivammathur
Copy link
Owner

@ausi This is now available in v2.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Sep 7, 2020
@swissspidy swissspidy mentioned this issue Sep 11, 2020
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivammathur shivammathur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

2.5.0 shivammathur/setup-php
2 participants
@ausi @shivammathur