Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

32 bits builds of PHP #326

Closed
1 task done
stof opened this issue Nov 1, 2020 · 5 comments · Fixed by #337
Closed
1 task done

32 bits builds of PHP #326

stof opened this issue Nov 1, 2020 · 5 comments · Fixed by #337
Assignees
Labels
enhancement New feature or request

Comments

@stof
Copy link

stof commented Nov 1, 2020

Describe the feature
Consider providing 32bit builds of PHP

Version

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue
Most CI setups of libraries are currently using PHP 64 bits builds. And then, from time to time, they receive issues like scssphp/scssphp#51 reporting bugs affecting only the 32 bits version of PHP.
Being able to have a CI running on a 32 bits build would help avoiding such cases (and preventing regressions).

Describe alternatives

  • Make php 32 bit die => not something we can do as library maintainers (even though it would simplify our issue...). That's something that the PHP core team would have to do, and I'm not aware of any plan to mandate 64 builds.
  • Maintain our own build of PHP for a 32 bits job. Symfony went with this option by using a 32 bit build in its Appveyor setup (but testing 32 bits and Windows at the same time might not be the best choice as we might need a matrix instead). But that requires more work.

Additional context

Are you willing to submit a PR?
I'm not familiar with the way this project works and where it takes PHP from, so not sure I can help.

@stof stof added the enhancement New feature or request label Nov 1, 2020
@shivammathur
Copy link
Owner

Duplicate #302
Please refer to #302 (comment)

@stof
Copy link
Author

stof commented Nov 1, 2020

@shivammathur sorry, I missing that in the search.
What about including some doc about that rather than relying on a comment in a closed issue ?

@shivammathur
Copy link
Owner

Yes, you are right.
I will add this to the documentation.

@stof
Copy link
Author

stof commented Nov 2, 2020

@shivammathur should this issue be re-opened until the doc gets updated so that it does not get forgotten ?

@shivammathur
Copy link
Owner

@stof
This is now documented in the README.
https://github.com/shivammathur/setup-php#multi-arch-setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants