Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic composer tool support #442

Closed
SamMousa opened this issue Apr 14, 2021 · 4 comments
Closed

Generic composer tool support #442

SamMousa opened this issue Apr 14, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@SamMousa
Copy link

Describe the feature
Currently all tools need to be manually registered in the code (tools.ts) of this package.

Version
Feature is not in master

Underlying issue
Function addTools uses a large switch statement and exact matching.

Describe alternatives
I propose adding a prefix for composer; for example: composer/scrutinizer/ocular would install the scrutinizer/ocular tool.

Additional context
This feature would reduce load because specific tools don't need to be added if they are available as composer package.

Are you willing to submit a PR?
Yes!

@SamMousa SamMousa added the enhancement New feature or request label Apr 14, 2021
@shivammathur
Copy link
Owner

What would be the advantage in your opinion of adding this feature as compared to adding a step to install composer packages after setup-php.

I think composer prefix would be redundant, scrutinizer/ocular or anything matching user/tool can be passed to composer.

@SamMousa
Copy link
Author

Good point on the redundancy of a prefix. My main reason for this feature request is that I need to install global composer package x and don't want to create a PR in this repo for every package.

I'm definitely flexible in the way we organise it, being a part of the tools syntax or a separate part of the config both will work fine and is up to your preference I guess

@shivammathur shivammathur added the awaiting-release Added/Fixed and tested, awaiting release label Apr 16, 2021
@SamMousa
Copy link
Author

23393c4

@shivammathur
Copy link
Owner

Added in 2.11.0.

@shivammathur shivammathur removed the awaiting-release Added/Fixed and tested, awaiting release label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants