Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate how to split VisitRepository and others #1329

Closed
acelaya opened this issue Jan 16, 2022 · 1 comment · Fixed by #1629
Closed

Investigate how to split VisitRepository and others #1329

acelaya opened this issue Jan 16, 2022 · 1 comment · Fixed by #1629
Milestone

Comments

@acelaya
Copy link
Member

acelaya commented Jan 16, 2022

Some repositories have become too big. Maybe encapsulating the logic in custom repositories that get the regular one injected would allow to split the logic.

@acelaya acelaya modified the milestones: 3.0.0, 3.1.0 Jan 16, 2022
@acelaya acelaya modified the milestones: 3.1.0, 3.2.0 Apr 23, 2022
@acelaya acelaya modified the milestones: 3.2.0, 3.3.0 Jul 28, 2022
@acelaya acelaya added this to Shlink Aug 8, 2022
@acelaya acelaya moved this to Todo 🗒️ in Shlink Aug 8, 2022
@acelaya acelaya removed this from the 3.3.0 milestone Sep 9, 2022
@acelaya acelaya removed this from Shlink Sep 9, 2022
@acelaya acelaya added this to Shlink Sep 25, 2022
@acelaya acelaya moved this to Todo 🗒️ in Shlink Sep 25, 2022
@acelaya acelaya removed the status in Shlink Sep 25, 2022
@acelaya acelaya changed the title Investigate how to split VisitsRepository Investigate how to split VisitRepository and others Dec 14, 2022
@acelaya acelaya moved this to In Progress 📝 in Shlink Dec 14, 2022
@acelaya acelaya added this to the 3.4.0 milestone Dec 14, 2022
@acelaya
Copy link
Member Author

acelaya commented Dec 14, 2022

Finally created a new factory that allows injecting repositories with split logic, but they currently have to extend doctrine's EntityRepository, as not all methods are public and encapsulating them instead makes some tasks too complex. Even more while using happyr/doctrine-specification.

Not ideal, but an improvement over having a gigantic single repository which is not accessed byt resolved via $em->getRepository(...)

@acelaya acelaya moved this from In Progress 📝 to In review 👀 in Shlink Dec 14, 2022
Repository owner moved this from In review 👀 to Done ✅ in Shlink Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant