Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make visits expose information of the short URL that was visited to produce them #2180

Open
acelaya opened this issue Aug 23, 2024 · 0 comments
Labels

Comments

@acelaya
Copy link
Member

acelaya commented Aug 23, 2024

Summary

For historical reasons, the Visit API model does not expose any information of the short URL that was visited to produce it.

This is because originally you could only get visits for a specific short URL, so the URL was implicit.

However, the API has evolved a lot since, with the ability to get visits for a domain, tag or all visits together. This means it would now be a more useful information.

Perhaps exposing the whole ShortUrl model for every visit would be a bit overkill, but at least a way to uniquely identify a short URL (domain + shortCode/customSlug and potentially short URL just for convenience) so that it can be used to query the short URL via other endpoints.

Use case

This would help users cross-reference the short URL that generated a particular visit when listing visits that belong to different short URLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant