Github Releases

[devmount]

Just a quick question: Is there a particular reason, why there are "only" git tags for Shoelace versions and no "real" GitHub releases? I'm asking because I see the following advantages of the latter:

• The current version of Shoelace would show up directly on the repository start page on GitHub
• I can get notified, if a new version is released (which doesn't work, if there are only tags and no GitHub releases):
  

If you don't want to bother creating releases manually, you can automate that with GitHub actions on tag creation. Let me know, if I can be of any help here, if you'd like that.

[claviska]

If you don't want to bother creating releases manually, you can automate that with GitHub actions on tag creation. Let me know, if I can be of any help here, if you'd like that.

I haven't used GitHub Actions yet, but this sounds like the right way forward. What will this entail?

[devmount]

This means, you simply add a release.yml config file (can have any filename) in .github/workflows. Then you follow GitHub actions syntax to create the behavior you want. Quick example:

name: Create GitHub Release
# only trigger this action when a git tag is pushed
on:
  push:
    tags:
    - '*'
# definition of what should be done when triggered
jobs:
  release:
    # TODO: get latest tag
    # TODO: create github release named like latest tag

I can create a PR with a complete config file if you like.

[claviska]

I’m good with this. Can we make sure it doesn’t run on every tag though? It should only trigger a release for tags that look like version numbers.

[devmount]

Of course, you can use glob patterns here.

The most simple would be all tags starting with a v:

on:
  push:
    tags:
      - "v*"

You can also explicitly allow specific versions, e.g.:

on:
  push:
    tags:
      - "v2.*"
      - "v3.*"

Or you can make it most complicated by specifying the exact patterns, e.g. (untested):

on:
  push:
    tags:
      - "v[0-9]+.[0-9]+.[0-9]+"             # for stable releases
      - "v[0-9]+.[0-9]+.[0-9]+-beta.[0-9]+" # for beta releases

What would you like?

[claviska]

I like v2.* because it’s a good balance between simple and not getting false positives.

[devmount]

Alright, PR is on its way 🚀

[claviska]

Thanks! Seems to work great. https://github.com/shoelace-style/shoelace/releases

[devmount]

Great! I got my beloved notification about a new shoelace release now 😍

[claviska]

Awesome. I'll still curate announcements on Twitter as well.

[devmount]

Of course, didn't follow you yet - my bad 🙈