Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken css in button styles file #1974

Closed
kirchsuSICKAG opened this issue Apr 12, 2024 · 1 comment
Closed

Broken css in button styles file #1974

kirchsuSICKAG opened this issue Apr 12, 2024 · 1 comment
Labels
bug Things that aren't working right in the library.

Comments

@kirchsuSICKAG
Copy link
Contributor

kirchsuSICKAG commented Apr 12, 2024

Describe the bug

With following PR #1928 a bug was added to the new shoelace version 2.15.0.
In the file button.style.ts line 593 the css selector was changed from
:host(.sl-button-group__button[checked]) {
to
:host([data-sl-button-group__button[checked]]) {

The new selector is no longer a valid css selector, which leads to that the followed css is no longer applied and so the right focus border is not shown (see screenshot)

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://codepen.io/kirchsuSICKAG/pen/OJGEEqO or to the button-group page of shoelace https://shoelace.style/components/button-group
  2. Tab to the first sl-button so it is getting focus
  3. Have a look at the applied styling of the focused button
  4. There is not styling applied although because of this line :host([data-syn-button-group__button--focus]), there should be an applied styling

Screenshots

Bildschirmfoto 2024-04-12 um 10 18 25

Browser / OS

  • OS: Mac
  • Browser: Chrome
  • Browser version: 123.0.6312.105

Additional information

The bug can be fixed by changing line 593 of the button.style.ts to
:host([data-syn-button-group__button][checked]) {

@kirchsuSICKAG kirchsuSICKAG added the bug Things that aren't working right in the library. label Apr 12, 2024
@KonnorRogers
Copy link
Collaborator

Fixed in #1975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library.
Projects
None yet
Development

No branches or pull requests

2 participants