Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling goToSlide before first render generates a console error #2296

Closed
patrick-mcdougle opened this issue Dec 3, 2024 · 0 comments · Fixed by #2295
Closed

Calling goToSlide before first render generates a console error #2296

patrick-mcdougle opened this issue Dec 3, 2024 · 0 comments · Fixed by #2295
Labels
bug Things that aren't working right in the library.

Comments

@patrick-mcdougle
Copy link
Contributor

Describe the bug

If you call goToSlide after construction, but before the first render, you get a console error because the scrollContainer doesn't exist yet.

To Reproduce

Steps to reproduce the behavior:

  1. Construct a carousel
  2. Call goToSlide on it before the first render
  3. See this console error

Screenshots

Screenshot 2024-12-02 at 2 57 34 PM

Browser / OS

  • OS: Any
  • Browser: Any
  • Browser version: N/A
@patrick-mcdougle patrick-mcdougle added the bug Things that aren't working right in the library. label Dec 3, 2024
This was referenced Dec 3, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Things that aren't working right in the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Race Condition if goToSlide is called too early rothy-s/shoelace
1 participant
@patrick-mcdougle