Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography / core element stylesheet #413

Closed
claviska opened this issue Apr 12, 2021 · 6 comments
Closed

Typography / core element stylesheet #413

claviska opened this issue Apr 12, 2021 · 6 comments
Assignees
Labels
feature Feature requests. themes Anything to do with the theming.

Comments

@claviska
Copy link
Member

claviska commented Apr 12, 2021

This is a proposal to offer an optional extension to the base stylesheet that will apply light DOM styles to core HTML elements, much like Tailwind's typography plugin.

This will give users a simple, opt-in way to achieve consistent styling throughout their app without requiring them to style everything from scratch using Shoelace's design tokens.

The proposed stylesheet will cover things like:

To emphasize — these will not be components, but a light DOM stylesheet that users can opt into. The stylesheet will set default styles for core HTML elements like this:

h1 {
  font-family: var(--sl-heading-font-family);
  font-weight: var(--sl-heading-font-weight);
  ...
}

Additional design tokens (such as the ones shown above) will be added to base.css to facilitate this objective. Actual tokens needed are TBD, as is the name of the new stylesheet.

I don't think anyone will be opposed to this, but feel free to post your thoughts below. To support the feature, use 👍 below.

@claviska claviska added the themes Anything to do with the theming. label Apr 12, 2021
@claviska claviska added this to the v2.0.0 release milestone Apr 12, 2021
@claviska claviska self-assigned this Apr 12, 2021
@claviska claviska mentioned this issue Apr 12, 2021
@jaredcwhite
Copy link
Contributor

@DeadWisdom
Copy link

Please give me clear docs on using them in the lightDOM and shadowDOM at the same time, then yes.

@johnspurlock
Copy link

New to Shoelace, and this sounds very useful for new prototypes - is a preview version of this core element stylesheet available on a cdn somewhere?

@claviska
Copy link
Member Author

There's nothing to preview just yet. It's still on the TODO list.

@claviska claviska modified the milestones: 2.0 (stable), 3.0 (future) Nov 8, 2022
@claviska claviska changed the title RFC: Typography / core element stylesheet Typography / core element stylesheet Nov 16, 2022
@claviska claviska unpinned this issue Nov 16, 2022
@erutan
Copy link

erutan commented Feb 1, 2023

This would be great - I have a project coming up that I'm going to build with astro as it'll be mostly pre-rendered / static with a few hydrated islands in it. Having a basic elements styled css variables that tie into shoelace would be really useful for a base in building the traditional aspects site while having those styles automatically fall into any shoelace components.

If you'd want some help with this I have a little time I could put in - in the past I forked zurb's foundation and had it rolling into three different html/css prototypes as a submodule etc so thinking of well structured classic CSS is something I'm comfortable with.

Somewhat amusingly it'd be similar to the OG shoelace which I stumbled across https://davidwalsh.name/shoelace-css

@masi
Copy link

masi commented Apr 20, 2023

I'd like also an option with a smaller base CSS. I don't need all these shades of purple etc.

@shoelace-style shoelace-style locked and limited conversation to collaborators Oct 16, 2023
@claviska claviska converted this issue into discussion #1645 Oct 16, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
feature Feature requests. themes Anything to do with the theming.
Projects
None yet
Development

No branches or pull requests

6 participants