-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aspect Ratio component #436
Comments
No concerns here. I dont know how widely used |
Looks like we're not the first to take a more generic approach to this: https://radix-ui.com/primitives/docs/utilities/aspect-ratio |
@claviska I feel like theyre everywhere. Tailwind has a plugin for it: https://github.com/tailwindlabs/tailwindcss-aspect-ratio ChakraUI: https://chakra-ui.com/docs/layout/aspect-ratio |
After more thought, I don't like generalizing this into That said, it seems like images, videos, and embeds are the primary use case here, so the original request has been implemented as This component replaces |
Per this discussion, it may make sense to rename
<sl-responsive-embed>
to the more generic<sl-aspect-ratio>
and modify it to support:The logic will be the same for all use cases, but renaming will be a breaking change. It may be helpful to remember that this is a stop gap utility until browsers fully support
aspect-ratio
, after which this component can be deprecated.Any concerns or thoughts before making this update?
/cc @ParamagicDev
The text was updated successfully, but these errors were encountered: