Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the unit amount of ecotax for each order item #101

Open
blmage opened this issue Mar 31, 2021 · 1 comment
Open

Provide the unit amount of ecotax for each order item #101

blmage opened this issue Mar 31, 2021 · 1 comment

Comments

@blmage
Copy link
Contributor

blmage commented Mar 31, 2021

Currently, it appears that the price returned for each order item does not include the corresponding amount of ecotax, and that the only way to determine whether ecotax has been applied to an order is to check whether the sum of the prices is less than the productAmount of the order.

This implies in turn that there is no reliable way to know the exact amount of ecotax applied to a given item.

Would it be possible to provide this information via a getEcotaxAmount method on OrderItem?

@blmage
Copy link
Contributor Author

blmage commented Apr 30, 2021

Could you please look into this as soon as possible?

I would prepare a PR, but it seems that the ecotax amounts are also missing from the API responses: https://developer.shopping-feed.com/order-api/order/v1store-orderfetch.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant