Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no inventory updated #52

Merged
merged 5 commits into from
Sep 3, 2018

Conversation

ddattee
Copy link
Contributor

@ddattee ddattee commented Aug 3, 2018

Reason for this PR

When inventory update is requested but none go throught then API return an empty result.

What does the PR do

Handle API return when to inventory have been updated in the ones that was requested.

Out of scope

Adding some missing ut

@ddattee ddattee added the bug Something isn't working label Aug 3, 2018
@ddattee ddattee self-assigned this Aug 3, 2018
@ddattee ddattee requested review from ronan-gloo and mdumoulin August 3, 2018 08:55
@ddattee ddattee changed the base branch from master to develop August 7, 2018 13:37
@ronan-gloo
Copy link
Contributor

@ddattee can you provides a test case that cover this issue please ?

@ddattee ddattee force-pushed the fix-no-inventory-returned branch from ceca4a5 to 63880ad Compare September 3, 2018 09:13
@ddattee ddattee merged commit 7b323ab into shoppingflux:develop Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants