Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: error message in not clear when existing shorebird installation is detected #31

Open
1 task
AbhijithKonnayil opened this issue Apr 3, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AbhijithKonnayil
Copy link

AbhijithKonnayil commented Apr 3, 2024

Description
When installing shorebird with
curl --proto '=https' --tlsv1.2 https://raw.githubusercontent.com/shorebirdtech/install/main/install.sh -sSf | bash
if existing shorebird installation is detected it shows the error,
Error: Existing Shorebird installation detected. Use --force to overwrite.
This error message gives only little context, atleast for beginners.
The proper command that works is
curl --proto '=https' --tlsv1.2 https://raw.githubusercontent.com/shorebirdtech/install/main/install.sh -sSf | bash -s -- --force

Requirements

# Check if install_dir already exists
if [ -d "$(install_dir)" ]; then
  if [ "$FORCE" = true ]; then
    echo "Existing Shorebird installation detected. Overwriting..."
    rm -rf "$(install_dir)"
  else
    echo >&2 "Error: Existing Shorebird installation detected. Use --force to overwrite."
    exit 1
  fi
fi

@eseidel eseidel added enhancement New feature or request good first issue Good for newcomers labels Apr 3, 2024
@babasahi
Copy link

Hi @eseidel,

I’d like to submit a PR for this. Since the install script is in the install repo, should this issue be moved there? Can you move it, or should I do it manually?

Thanks!

@eseidel eseidel transferred this issue from shorebirdtech/shorebird May 20, 2024
@eseidel
Copy link
Contributor

eseidel commented May 20, 2024

Transfered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants