Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect crashes and roll-back patches automatically #1875

Closed
eseidel opened this issue Apr 8, 2024 · 1 comment
Closed

feat: detect crashes and roll-back patches automatically #1875

eseidel opened this issue Apr 8, 2024 · 1 comment

Comments

@eseidel
Copy link
Contributor

eseidel commented Apr 8, 2024

We currently have code in our engine fork to detect problems during Dart initialization and "mark the patch bad" (e.g. roll it back).

However we don't currently catch other kinds of crashes, but could. e.g. #1826

My understanding of the way Expo does this in their OTA product is by setting a timer for ~5 seconds on launch, if the timer fires it marks the patch as good.

Obviously there would be caveats with potentially needing to catch users killing the app (to not mark the patch bad)?

We also could just more directly catch the crash (like crashlytics or sentry would) and mark the patch bad that way.

@eseidel
Copy link
Contributor Author

eseidel commented Apr 17, 2024

Bryan is fixing this in shorebirdtech/engine#79.

@eseidel eseidel closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant