Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-land cache update patch #1977

Open
felangel opened this issue Apr 25, 2024 · 3 comments
Open

feat: re-land cache update patch #1977

felangel opened this issue Apr 25, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@felangel
Copy link
Contributor

Re-land #1958 which was reverted in #1975.

Also ideally complete #1976 as part of this work to prevent future regressions.

@felangel felangel added the enhancement New feature or request label Apr 25, 2024
@felangel
Copy link
Contributor Author

FYI @bryanoltman

@eseidel
Copy link
Contributor

eseidel commented May 30, 2024

There have been a few cache-related issues of late:

  1. This one (pre-caching)
  2. Installing only one version of Flutter on CI (instead of both the latest as well as the one the user requests with flutter-version in our GHA) feat: Specify flutter version and/or disable automatic download setup-shorebird#18. Also feat: precache flutter during shorebird install install#33
  3. Making shorebird update actually do the full upgrade (without requiring a second run of shorebird). flutter knows how to do this, we'd just need to look and see. feat: shorebird upgrade should compile shorebird #289 feat: shorebird upgrade should print the new version number. #288
  4. Cache artifact validation (we don't currently check in or confirm hashes for downloaded artifacts, which means that sometimes they don't survive the download/extraction, e.g. bundletool. fix: bundletool.jar download is sometimes corrupt (need to verify artifacts) updater#175

@eseidel
Copy link
Contributor

eseidel commented May 30, 2024

Some subset of those might be something someone could take on when they're next paged-in on our caching logic.

@bryanoltman bryanoltman removed their assignment Jun 21, 2024
@erickzanardo erickzanardo self-assigned this Jun 25, 2024
@eseidel eseidel moved this from Todo to Punted in 1.1 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Punted
Development

No branches or pull requests

4 participants