Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shorebird release should save off build arguments and shorebird patch should use them #2407

Open
eseidel opened this issue Aug 8, 2024 · 2 comments

Comments

@eseidel
Copy link
Contributor

eseidel commented Aug 8, 2024

Right now it's possible to pass one set of --dart-defines when releasing and a different one when patching.

Maybe that's a feature? But it also feels like maybe something we should automatically match for you (or at least offer to?) when patching. Otherwise you could accidentally end up with a much larger patch than you expect.

@eseidel
Copy link
Contributor Author

eseidel commented Oct 10, 2024

Similarly it's possible to pass --obfuscate to one but not the other (which can cause confusing results).

Even if we didn't use them, there are probably some flags we should save/check-for between the two.

@eseidel
Copy link
Contributor Author

eseidel commented Dec 18, 2024

This came up again today. At least warning a user "oh, btw, you passed --dart-defines to release, but not to patch" or similar would be sufficient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Support Burden
Development

No branches or pull requests

1 participant