Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate build and upload steps (add upload option) #2630

Open
2 tasks
MohiuddinM opened this issue Nov 19, 2024 · 2 comments
Open
2 tasks

feat: separate build and upload steps (add upload option) #2630

MohiuddinM opened this issue Nov 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@MohiuddinM
Copy link

Description

Right now the cli only has release cmd that builds and uploads together. We should allow both of these steps to be called separately.

Requirements

  • add shorebird build command that only builds the artifacts (this cmd takes the same args as the release cmd)
  • add shorebird upload command that uploads a previously generated artifact (this cmd takes path of an artifact as arg)
@MohiuddinM MohiuddinM changed the title feat: separate build and upload (add upload option) feat: separate build and upload steps (add upload option) Nov 19, 2024
@bryanoltman
Copy link
Contributor

It is intentional that we don't separate these two, as it is often that case that people lose track of which build was made when. What are you hoping to accomplish by splitting these apart?

@MohiuddinM
Copy link
Author

We can keep the release command as is, so existing use will not be affected, and people use build and upload separately only when they know what they are doing.

I need this so I can sign the artifact on a separate server.

@eseidel eseidel added the enhancement New feature or request label Nov 21, 2024
@eseidel eseidel added this to 1.1 Nov 21, 2024
@eseidel eseidel moved this to Customers in 1.1 Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Customers
Development

No branches or pull requests

3 participants