-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: arm and x86_64 patches are 1.xx KB, but arm64 patch is 1.xx MB #2749
Comments
And I found that x86_64 and arm patches' hashes are the same after running |
Hmm, that's surprising. Thank you for the report, we can look. |
Attempting to reproduce now with a trivial example (the default Flutter "counter" app, changing the theme color for the patch). I'm seeing an arm64 patch size that is very slightly higher than the other architectures, but only barely:
Can you provide more information about your app?
|
|
It may also just be randomness from the Dart compiler. I'm not sure why the arm64 binary would change so much, but it's possible that when we use our fancier compiler tech (that we use on iOS but not currently Android), this issue will resolve itself: |
but after making patches again, x86_64 and arm patches' hash is the same with last patches'. Is it expected? |
I'm not sure what you mean by "x86_64 and arm patches' hash is the same with last patches". Where are you getting the hash values? |
I got the hashes from log. |
Can you share the full logs? |
I have tried to create patch again, it seem everything ok. But this patch deleted chanege one dart file. hmm |
App ID: 42c91bdd-f4e7-40ac-b273-9c4bbdd63919
Description
The patch size should be similar size across different platforms, but currently, the ARM64 version is significantly larger while other architectures remain small.
Steps To Reproduce
Expected Behavior
Patches are similar size.
**Patches Log **
The text was updated successfully, but these errors were encountered: