Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make it possible to only install Shorebird and get Flutter + Dart #434

Closed
eseidel opened this issue May 3, 2023 · 4 comments
Closed
Labels
enhancement New feature or request

Comments

@eseidel
Copy link
Contributor

eseidel commented May 3, 2023

I doubt we need to do this soon, but eventually we will want to find a different way to hook our shorebird engine into Flutter.

It would allow use of the flutter from shorebird for buiding release builds w/o shorebird (e.g a --no-codepush variant). This would allow users to just use the vended copy of Flutter and not have to install their own.

It also could pave the way for us to provide more build options (not just codepush) since it's likely that we will want to have different codepush build methods once we have an interpreter mode for iOS (that we might also want to offer on Android).

@eseidel
Copy link
Contributor Author

eseidel commented May 3, 2023

https://docs.google.com/document/d/1z_4Z5JMTbk5c4FpayVAb-PTz2wLP-aSCirbieavT3Ws/edit?pli=1 might be relevant (although it looks dead).

@eseidel eseidel changed the title feat: Be able to use shorebird flutter with shorebird turned off feat: Make it possible to only install Shorebird and get Flutter + Dart Jul 26, 2023
@eseidel
Copy link
Contributor Author

eseidel commented Jul 26, 2023

This blocks our ability to be the way you install Flutter.

@eseidel
Copy link
Contributor Author

eseidel commented Apr 19, 2024

I think we could start this by just pulling our own dart (same way that flutter does), even if we don't make it available to others. That removes our dependency on what version of dart you have in your path.

@eseidel eseidel added the enhancement New feature or request label Jun 12, 2024
@eseidel
Copy link
Contributor Author

eseidel commented Jun 12, 2024

We would have to do a lot to get here. I'm not sure this is worth keeping open as a bug for now.

@eseidel eseidel closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant