Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patches sometimes uninstall right after install (package:flutter_foreground_task) #211

Closed
eseidel opened this issue Sep 3, 2024 · 0 comments · Fixed by shorebirdtech/engine#87
Assignees

Comments

@eseidel
Copy link
Contributor

eseidel commented Sep 3, 2024

Two customers have reported a bad (occasional) interaction between Shorebird and some plugins which create a FlutterEngine, (but don't actually use it), causing Shorebird's launch tracking to get confused and think a patch crashed an uninstall it right away.

This only happens if the plugin (in this case, package:flutter_foreground_task) is invoked right between when a patch is installed before it it successfully launched from.

The bug is our fault. Our launch tracking gets confused by (surprising) behavior from the plugin which we need to fix.

@bryanoltman is working on a fix, which we hope to release later this week. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants