Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Suggestion: Volume EG for partials #213

Closed
Visuelle-Musik opened this issue Sep 14, 2024 · 1 comment · Fixed by #215
Closed

Feature Suggestion: Volume EG for partials #213

Visuelle-Musik opened this issue Sep 14, 2024 · 1 comment · Fixed by #215

Comments

@Visuelle-Musik
Copy link

I would be cool if wave=amy.PARTIALS could additionally have a master-volume envelope
Also see this discussion: "Interaction of voices and oscillators" #191

@dpwe
Copy link
Collaborator

dpwe commented Sep 14, 2024

Yes, I like this. Currently the amplitude envelope is applied with within-block linear interpolation during the waveform generation for basic wave shapes (SINE, PULSE, SAW, TRIANGLE), applied piecewise-constant within blocks for NOISE, KS, PCM, but ignored for PARTIALS (other than the propagation of velocity to each of the component partials).

It also appears that pitch modulation is only applied at the creation of individual partials, after which they continue at a fixed base pitch (modified by their frequency modulation contour). Dynamic filtering is already correctly applied to PARTIALS outputs.

Adding overall amplitude modulation following the amplitude envelope of the main PARTIALS oscillator should be added. Also, pitch modulation of that oscillator should propagate down to individual partials frame-by-frame.

Also see #214 for additional PARTIALS modes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants