New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka rack aware routing bug #1704

Open

rukai opened this issue Jul 25, 2024 · 0 comments

Labels

Member

rukai commented Jul 25, 2024 •

edited

Loading

I noticed a bug in rack aware routing:

shotover-proxy/shotover/src/transforms/kafka/sink_cluster/mod.rs

Lines 949 to 952 in 4c146b8

 None => Ok(KafkaNode::new( 

 coordinator.node_id, 

 KafkaAddress::new(coordinator.host.clone(), coordinator.port), 

 None,

This code path adds a node with no rack and there is no way to override that None rack later on.
We need to do one of:

not add a node here
add a way to replace the rack later on
immediately fetch the full node info here

rukai added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment