Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KafkaSinkCluster - move destination field from PendingRequestState into PendingRequest #1763

Open
rukai opened this issue Oct 3, 2024 · 0 comments
Open

KafkaSinkCluster - move destination field from PendingRequestState into PendingRequest #1763

rukai opened this issue Oct 3, 2024 · 0 comments
Labels
cleanup-internal Any cleanup that is not cleanup-api good first issue Good for newcomers

Comments

@rukai
Copy link
Member

rukai commented Oct 3, 2024

Every variant of the PendingRequestState enum contains a destination field of the same Destination type.
This is redundant and we would be better off just storing this value once in PendingRequest.

Doing so should simplify things by avoiding having to pass destination between each variant as we move between states.
@rukai rukai added good first issue Good for newcomers cleanup-internal Any cleanup that is not cleanup-api labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup-internal Any cleanup that is not cleanup-api good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rukai