Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster - Split OffsetFetch requests #1764

Open
rukai opened this issue Oct 3, 2024 · 0 comments
Open

KafkaSinkCluster - Split OffsetFetch requests #1764

rukai opened this issue Oct 3, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rukai
Copy link
Member

rukai commented Oct 3, 2024

refer to comment:

// This is possibly dangerous.
// The client could construct a message which is valid for a specific shotover node, but not for any single kafka broker.
// We may need to add some logic to split the request into multiple messages going to different destinations,
// and then reconstruct the response back into a single response
//
// For now just pick the first group as that is sufficient for the simple cases.
offset_fetch.groups.first().unwrap().group_id.clone()

similar to #1666

@rukai rukai added the bug Something isn't working label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant