You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not happy with how currency formatter is adding this fat 1400 lines of unnecessary codes to our codebase. Maybe we can remove all the unwanted currencies from this module and use it as an internal one?
The text was updated successfully, but these errors were encountered:
This currency formatter is not the best solution as we will get rid of it once we go i18n (#11) – however that specific file, compressed, is less than 2KB, so not that big deal. We should get rid of material-ui first, as it weight 1/3 of our bundle :P
But it could easily be simplified in a couple of lines of code. I'm not suggesting to get rid of it, I'm saying we can remove unnecessary currencies from the above file and import it internally. If you agree I can do it in my spare time?
I can't see the reason of changing it. I see only disadvantages: we wouldn't be able to update the dependency if the module is updated, we should add tests, we would need to take double care once we switch to react-intl, we need to refactor the imports, etc. all this for saving few bytes seems too much 😄
Well, I'm not sure if it's a module with update potential or the situation is as bad as you describe it 😣 but okay if you think so. Just didn't feel good about all those lines. I am closing this issue.
I'm not happy with how currency formatter is adding this fat 1400 lines of unnecessary codes to our codebase. Maybe we can remove all the unwanted currencies from this module and use it as an internal one?
The text was updated successfully, but these errors were encountered: