Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option not to install CLI locally — use globally installed #42

Open
mrdimidium opened this issue May 3, 2019 · 9 comments
Open

Option not to install CLI locally — use globally installed #42

mrdimidium opened this issue May 3, 2019 · 9 comments
Labels
feature New feature or request plan This task is a linear part of the development planned for development.

Comments

@mrdimidium
Copy link

mrdimidium commented May 3, 2019

The main volume is @shower/cli. We can add the ability to use globally installed @shower/cli from the presentation, and locally put only theme/core and the like.

Originally posted by @nikolay-govorov in shower/shower#349 (comment)

@mrdimidium mrdimidium added feature New feature or request plan This task is a linear part of the development planned for development. labels May 3, 2019
@mrdimidium
Copy link
Author

Propose a such API: add in the command create the item «Install the CLI locally?».
If we find globally installed CLI suggest false by default otherwise suggest true.

@pepelsbey, what are you think?

@pepelsbey
Copy link

Sounds… complicated. Maybe we shouldn’t have bundled CLI into Shower in the first place?

We can make it global only again and suggest installing CLI instead of providing npm scripts.

@mrdimidium
Copy link
Author

That's possible. On the other hand, what if you still want to use the local version? How to be if the global version is not installed (for example, when the repository was tilted by another person, or to a new one)? There may also be problems with different versions of the CLI and library. For example, after changing the shower-ribbon and @shower/ribbon, a new CLI can not get the old presentation.

The locally installed CLI works perfectly simply and reliably.

@mrdimidium
Copy link
Author

mrdimidium commented May 12, 2019

Fundamentally with the advent of CLI nothing has changed - before the project was gulpfile and its dependencies, and now the CLI and its dependencies.

In fact, and now you can manually remove it from package.json write about @shower/cli, and use globally installed. This will work.

@mrdimidium
Copy link
Author

@pepelsbey, what are you think?

@pepelsbey
Copy link

I think that the whole Chromium (Puppeteer) for every Shower presentation is way too much. 84.5 Mb to download and 199 Mb on disk just to print your presentation to PDF (which you may never use) is clearly not the best thing to have.

I’m talking about defaults here, not the option to remove something later, which no one would ever use. No, seriously: let’s make Shower as light as possible and suggest installing CLI tool globally for everyone who would like to use prepare, archive, print, etc.

@andriyor
Copy link
Contributor

I think that the best solution for reducing disk space usage would be using puppeteer-core with chrome-launcher. And if the user provides PUPPETEER_EXECUTABLE_PATH use that path, otherwise use path that provide chrome-launcher.
If you agree with that, I can make PR

@pepelsbey
Copy link

@nikolay-govorov what do you think?

@mrdimidium
Copy link
Author

I apologize for the long answer. Sounds great, let's do it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request plan This task is a linear part of the development planned for development.
Projects
None yet
Development

No branches or pull requests

3 participants