Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the lang option #50

Open
pepelsbey opened this issue Apr 17, 2020 · 4 comments
Open

Add the lang option #50

pepelsbey opened this issue Apr 17, 2020 · 4 comments
Labels
feature New feature or request

Comments

@pepelsbey
Copy link

Something like this:

<!DOCTYPE html>
<html lang="<%= lang %>">

It’s important to have a proper language set.
@mrdimidium
Copy link

Yes, that sounds great. What do you think this menu item should look like?

@pepelsbey
Copy link
Author

Something like

? Select language
❯ English
  Russian
  Custom…

That would give you lang="en" or lang="ru. In “Custom…” case you’ll be prompted to enter either language name or language code, depending on how you’re planning to implement it.

@mrdimidium
Copy link

There are a few details that I would like to consult about.

  1. Should the default language be English, or maybe the current system language?
  2. Whether to validate the language that the user enters in the custom? Probably by bcp47

@pepelsbey
Copy link
Author

It depends on how much time you want to spend working on this feature :) You can always just go for En, Ru, Custom… and keep developers responsible for their choice.

But as the next enhancement I’d validate the Custom value and only then work on guessing the default option.

@pepelsbey pepelsbey added the feature New feature or request label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pepelsbey @mrdimidium