Having some issues running docker/main.tf

[hussfelt]

Hey,

Looking through this file I get some small issues running terraform plan:
https://github.com/shuaibiyy/terraform-ecs-jenkins/blob/master/docker/main.tf

I am not really following how this was thought, therefore there is no PR. I ended up moving this code outside of the module.

• The variable image_name is not declared and have no default value
• The variable self.repository_url is unknown for me how it's supposed to work :)
• The variable jenkins_image_name could possibly be moved to a null-default value to break, and then instead commit a terraform.tfvars.default file with this defined to indicate change?

Either way, the way the modules I've touched so far all the values in a module should be passed down from the instantiated state - in this case I can't :-)

All above aside, as indicated before - I learned a lot from this module! Thanks!

[shuaibiyy]

Hey there,

I had initially wanted to use my own custom jenkins image. The idea was to build the image and push it to AWS ECR, and the scripts in the docker directory were supposed to achieve that. I ended up abandoning that approach and went with the official jenkins docker image.

If the scripts were to be used though, image_name should definitely be given a default value as you note using whatever approach. self.repository_url would be the value of whatever the computed URL of the aws_ecr_repository resource is after the tf script is applied.

[hussfelt]

Hey! Any particular reson the idea was abandoned? :) I am currently doing just that, maybe for no reason... In my case I am just doing some labs, to get into ECS and automation with Jenkins. Either way, as the issue is not relevant, feel free to close :) Thanks again! Cheers!

[ajay1007]

Hi,
Could you please update docker image with jenkins image? That will be helpful or please share ideas on how to fix docker folder issue?