Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Refactor GET-many endpoints in deployer to allow pagination #845

Closed
4 tasks done
AlphaKeks opened this issue May 2, 2023 · 3 comments · Fixed by #862
Closed
4 tasks done

[Feature]: Refactor GET-many endpoints in deployer to allow pagination #845

AlphaKeks opened this issue May 2, 2023 · 3 comments · Fixed by #862
Assignees

Comments

@AlphaKeks
Copy link
Contributor

AlphaKeks commented May 2, 2023

Describe the feature

We should implement pagination for the endpoints that get a list of items from the deployer and gateway. This will be useful for CLI users so they can get only a subset of e.g. projects, rather than all of them. It will also be useful for the console, so we can fetch a subset at a time, rather than fetch them all and then paginate them in the browser.

  • Implement pagination for project list (”/projects” endpoint on the router in gateway/api/latest)
  • Implement pagination for deployment list
  • Consider whether we should follow this up with some filtering, e.g. should we be able to filter project list by project state?

Suggestion or Example of how the feature would be used

Are there more endpoints we should implement this for? Should we consider using cursor pagination for this?

Duplicate declaration

  • I have searched the issues and this feature has not been requested before.
@AlphaKeks
Copy link
Contributor Author

Pagination for project list implemented here

@AlphaKeks
Copy link
Contributor Author

AlphaKeks commented May 4, 2023

Pagination for deployment list implemented here

@oddgrd oddgrd added SB2 labels May 4, 2023
@oddgrd
Copy link
Contributor

oddgrd commented May 4, 2023

Awesome, thanks! Feel free to open a PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants