Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem to get meta image #77

Open
MirianBebee opened this issue May 14, 2021 · 1 comment
Open

Problem to get meta image #77

MirianBebee opened this issue May 14, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@MirianBebee
Copy link

MirianBebee commented May 14, 2021

Good Morning,

I'm writing you because I have had a bug when obtaining the openGraph of a url, it does not get the image because it has escaped characters and it is not validated.

When using openGraph there are certain urls from which the image is not obtained correctly, and it is because a decode of the image should be added in the verify_image_url function.

Page example:
https://www.forbes.com/sites/forbescoachescouncil/2017/04/19/networking-or-job-boards-nine-strategies-to-find-your-next-role/

Image url:
https://thumbor.forbes.com/thumbor/fit-in/1200x0/filters%3Aformat%28jpg%29/https%3A%2F%2Fblogs-images.forbes.com%2Fforbescoachescouncil%2Ffiles%2F2017%2F04%2FNetworking-or-Job-Boards-Nine-Strategies-To-Land-Your-Next-Role.jpg

Solution:
$url = urldecode ($url);

Thanks in advance,

Mirian

@shweshi
Copy link
Owner

shweshi commented May 14, 2021

@MirianBebee Thanks for pointing out problem and proposing the solution. This certainly may cause the issue, and I think the proposed solution should work.
If you don't mind, I will encourage you to open a pull request with the proposed solution and contribute to improve the OpenGraph.

Thanks.

@shweshi shweshi added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants