Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: adding a recursive option to fetch .bib files ? #180

Closed
Thomzoy opened this issue Mar 8, 2023 · 2 comments
Closed

Feature: adding a recursive option to fetch .bib files ? #180

Thomzoy opened this issue Mar 8, 2023 · 2 comments

Comments

@Thomzoy
Copy link
Contributor

Thomzoy commented Mar 8, 2023

Hi !

First of all thanks for this great repo !
I forked it since in my project, I use multiple .bib files scattered across the docs folder. As such, I added a recursive option with a simple change when fetching the .bib files :

if self.config["recursive"]:
    bibfiles.extend(Path(self.config["bib_dir"]).rglob("*.bib"))
else:
    bibfiles.extend(Path(self.config["bib_dir"]).glob("*.bib"))

Would you be interested in a PR for this ?

@shyamd
Copy link
Owner

shyamd commented Mar 12, 2023

Would definitely appreciate the PR. No need to add recursive option. Just make it the default since that seems like a sensible expectation.

@shyamd
Copy link
Owner

shyamd commented Mar 16, 2023

This got released in v2.8.15
Thanks!

@shyamd shyamd closed this as completed Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants