Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a special reason to ignore unsigned values of numeric types? #188

Closed
sungjuly opened this issue Nov 20, 2017 · 3 comments
Closed

Comments

@sungjuly
Copy link

Thanks for making a great open source project! I've encountered unsigned/signed issues when ingesting MySQL binlog. I'm wondering is there a special reason to ignore unsigned values of numeric types? I assume there's additional information of unsigned/signed in table map for sure. It would be great if you share some materials to implement blind spots for this issue.

It seems this following method is to map column type from the metadata.
ColumnType.byCode(typeCode)
@shyiko
Copy link
Owner

shyiko commented Nov 20, 2017

Hi @sungjuly. See #104 (comment) (in short, the information needed to understand whether column was signed/unsigned at the time event was generated is missing (in the binary log)).

@shyiko shyiko closed this as completed Nov 20, 2017
@sungjuly
Copy link
Author

@shyiko thanks for clarifying on this!

@shyiko
Copy link
Owner

shyiko commented Nov 21, 2017

@sungjuly any time 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants