Skip to content

Commit 7edf91e

Browse files
committed
.github: let "make leaked-globals" run in parallel
This target can be a build matrix. Also it does not make sense to test it on mjit.
1 parent 732442f commit 7edf91e

File tree

3 files changed

+2
-8
lines changed

3 files changed

+2
-8
lines changed

.github/workflows/macos.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ jobs:
55
runs-on: macos-latest
66
strategy:
77
matrix:
8-
test_task: [ "check", "test-bundler", "test-bundled-gems" ]
8+
test_task: [ "check", "test-bundler", "test-bundled-gems", "leaked-globals" ]
99
fail-fast: false
1010
if: "!contains(github.event.head_commit.message, '[ci skip]')"
1111
steps:
@@ -52,8 +52,6 @@ jobs:
5252
# Remove minitest from TEST_BUNDLED_GEMS_ALLOW_FAILURES if https://github.com/seattlerb/minitest/pull/798 is resolved
5353
# rss needs to add workaround for the non rexml environment
5454
TEST_BUNDLED_GEMS_ALLOW_FAILURES: "minitest,xmlrpc,rss,rexml"
55-
- run: make -s leaked-globals
56-
working-directory: build
5755
- uses: k0kubun/action-slack@v2.0.0
5856
with:
5957
payload: |

.github/workflows/mjit.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,6 @@ jobs:
5454
working-directory: build
5555
- run: make $JOBS -s test-spec
5656
working-directory: build
57-
- run: make -s leaked-globals
58-
working-directory: build
5957
- uses: k0kubun/action-slack@v2.0.0
6058
with:
6159
payload: |

.github/workflows/ubuntu.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ jobs:
44
make:
55
strategy:
66
matrix:
7-
test_task: [ "check", "test-bundler", "test-bundled-gems", "test-all TESTS=--repeat-count=2" ]
7+
test_task: [ "check", "test-bundler", "test-bundled-gems", "test-all TESTS=--repeat-count=2", "leaked-globals" ]
88
os: [ubuntu-latest, ubuntu-16.04]
99
exclude:
1010
- test_task: test-bundler
@@ -64,8 +64,6 @@ jobs:
6464
# Remove minitest from TEST_BUNDLED_GEMS_ALLOW_FAILURES if https://github.com/seattlerb/minitest/pull/798 is resolved
6565
# rss needs to add workaround for the non rexml environment
6666
TEST_BUNDLED_GEMS_ALLOW_FAILURES: "minitest,xmlrpc,rss"
67-
- run: make -s leaked-globals
68-
working-directory: build
6967
- uses: k0kubun/action-slack@v2.0.0
7068
with:
7169
payload: |

0 commit comments

Comments
 (0)