Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smooth auth integration with GitHub #11

Closed
siavol opened this issue Jun 29, 2024 · 2 comments · Fixed by #26
Closed

Smooth auth integration with GitHub #11

siavol opened this issue Jun 29, 2024 · 2 comments · Fixed by #26

Comments

@siavol
Copy link
Owner

siavol commented Jun 29, 2024

It is inconvenient how to get token for a user. Would be easier to authenticate user in the app with GitHub and grant app access to the needed repo.
@siavol siavol changed the title Smooth integration with GitHub Smooth auth integration with GitHub Aug 3, 2024
@siavol
Copy link
Owner Author

siavol commented Aug 14, 2024

GitHub Apps documentation: https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/authenticating-with-a-github-app-on-behalf-of-a-user

This was referenced Aug 14, 2024
Open
Closed
@siavol
Copy link
Owner Author

siavol commented Aug 19, 2024 •
edited
Loading

Ok, its not possible to make it work from just a browser app, see isaacs/github#330
I need some cheap serverless function to exchange code to access token. Can not find smth ready, created a siavol/func-github-app-gatekeeper#1

@siavol siavol linked a pull request Aug 25, 2024 that will close this issue
11 smooth auth integration with GitHub #26
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

11 smooth auth integration with GitHub siavol/markdiary-web
1 participant
@siavol