Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too many fetch requests #532

Open
rjahn opened this issue Dec 16, 2024 · 3 comments
Open

too many fetch requests #532

rjahn opened this issue Dec 16, 2024 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rjahn
Copy link
Member

rjahn commented Dec 16, 2024

Not sure, but maybe a side-effect of another fix?

User: features
Screen: Contacts (DB)

image

Simply select a user and press "Abbrechen". Choose another user...

There are 2 or 3 fetch requests. Sometimes no fetch request, but often 2.
Why do we fetch so often?

@rjahn rjahn added the bug Something isn't working label Dec 16, 2024
@rjahn rjahn added this to the 2.3 milestone Dec 16, 2024
@gimmixAT
Copy link
Contributor

I can't reproduce this when switching between different contacts (either Chrome or FF). I just see multiple fetch requests when opening the first user.
The loads are the UIEditorLinked prefetching their options.

I'll see if updating the jvxmobile changes anything

@rjahn
Copy link
Member Author

rjahn commented Dec 17, 2024

with current repo version it's different:

After first open of screen: linked cell editors (salutation, academic title) will be fetched - if values are set. The health insurance won't be fetched if no value is set.

Linked Cell Editors should be fetched lazy - only on opening the picklist - or if I guess a concat mask is used. If there are many linked cell editors with large pick lists, it would slow down the system.

In my case, every record selection triggers 2 fetch requests with same payload - for the educations detail table. Sometimes 3 fetch requests...

AND first open of screen triggers 4 fetch requests?

The contacts should be sent with screen open request. Why do we send any fetch request after opening the screen?

The dataproviders should work this way:

The dataprovider is a container for records. UI controls should check the dataprovider if a record for xyz is available, if not -> fetch. Fetch requests are possible until server reports "all fetched".
If server sends dataProviderChanged with e.g. reload: -1 -> client dataprovider should be cleared and start fetching.

So, if client has a dataprovider which contains e.g. 4 records and UI requests columns of record 1 - no fetch should be required. If it requests record 5 -> fetch...

This behavior makes the UI faster and reduces record fetching.
Also linked cell editors should load "lazy" because it's not necessary to load picklist values until picklist opens or concat list is set.

The UI should work completely with lazy loading records.

@rjahn
Copy link
Member Author

rjahn commented Dec 17, 2024

4 fetch requests for opening the screen:

image

but openScreen should contain records already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants