Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Domain Integration #454

Closed
reppajm opened this issue Dec 10, 2021 · 8 comments
Closed

Custom Domain Integration #454

reppajm opened this issue Dec 10, 2021 · 8 comments

Comments

@reppajm
Copy link

reppajm commented Dec 10, 2021

AWS AppSync now Support Custom Domain Natively. https://aws.amazon.com/blogs/mobile/introducing-custom-domain-names-for-aws-appsync-apis/ it would be nice to support this in the plugin as well.

@bboure
Copy link
Collaborator

bboure commented Dec 20, 2021

Yes, this is something I'd like to support!
PRs are welcome :)

@bboure
Copy link
Collaborator

bboure commented Dec 20, 2021

Some useful links
AWS::AppSync::DomainName
AWS::AppSync::DomainNameApiAssociation

Additional thoughts:

  • Not sure how to handle CertificateArn. (ie: how to generate it), as it requires validating the domain, etc. Might need to be done manually and then copy the generated arn in the yaml file. Or, try to resolve it based on the domainName
  • serverless-domain-manager can be a useful resource to get inspiration

@tomaszdudek7
Copy link

I would recommend skipping generating ACM Certificate and just make custom:appsync:domain:certificateArn a required parameter.

Very often ACM Certificates are created and managed via other tools and other teams.

@okrasnokutskyi
Copy link

@bboure Looks like PR already merged. Is the issue still exist?

Any updates on when V2 will be release ready?

@bboure
Copy link
Collaborator

bboure commented Feb 12, 2022

@okrasnokutskyi-amplify that PR was for V2 which is not fully ready.
I want to release an alpha version of it soon.

Meanwhile I might work on backporting it to v1
no ETA though, sorry

@bboure
Copy link
Collaborator

bboure commented Feb 12, 2022

I backported the V2 custom domain support feature to the current version. It was easier than I expected 🙂

#475

Code reviews are welcome :)

@bboure
Copy link
Collaborator

bboure commented Mar 30, 2022

Supported in v1.13.0

Thank you for your patience

@reppajm
Copy link
Author

reppajm commented Mar 30, 2022

@bboure Thank you for making this happen in v1 🙌.

@reppajm reppajm closed this as completed Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants